Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jackson to version 2.12.1. #2812

Conversation

PascalSchumacher
Copy link
Contributor

Spring Boot 2.4 supports Jackson 2.12, so this update should be possible.

@PascalSchumacher PascalSchumacher force-pushed the update_jackson_to_2.12.1 branch 2 times, most recently from 321ead1 to 776ce72 Compare February 18, 2021 18:56
@dbmalkovsky
Copy link
Contributor

Some of the failures are:

java.lang.IllegalArgumentException: Java 8 date/time type `java.time.Instant` not supported by default: add Module "com.fasterxml.jackson.datatype:jackson-datatype-jsr310" to enable handling

which indicates adding this dependency may help:

<dependency>
    <groupId>com.fasterxml.jackson.datatype</groupId>
    <artifactId>jackson-datatype-jsr310</artifactId>
    <version>${jackson.version}</version>
</dependency>

@dbmalkovsky
Copy link
Contributor

dbmalkovsky commented Feb 19, 2021

@PascalSchumacher when I pulled your PR and added the jar as noted above I got a clean build and test.
I am assuming the new jar is also added to the notice.txt file.

@PascalSchumacher
Copy link
Contributor Author

@dbmalkovsky Thanks, but the question is: Why is jackson-datatype-jsr310 required when using Jackson 2.12?

On further thinking I believe it is best to wait with the update until Spring Boot uses Jackson 2.12 too.

@PascalSchumacher
Copy link
Contributor Author

I guess this is the reason for the test failures: FasterXML/jackson-databind#2683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants